Don't start the BFT mining coordinator when it is created, just enable it#6675
Merged
matthew1001 merged 4 commits intobesu-eth:mainfrom Mar 12, 2024
Merged
Don't start the BFT mining coordinator when it is created, just enable it#6675matthew1001 merged 4 commits intobesu-eth:mainfrom
matthew1001 merged 4 commits intobesu-eth:mainfrom
Conversation
matthew1001
changed the title
jframe
reviewed
Mar 7, 2024
Contributor
jframe
left a comment
jframe
left a comment
There was a problem hiding this comment.
Changes look good, it would be good add a changelog entry as well
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
matthew1001
force-pushed
the
no-bft-start
branch
from
2dbac56 to
315d656
Compare
Contributor
Author
Thanks @jframe, I've added it to the bugs list in the changelog |
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
matthew1001
force-pushed
the
no-bft-start
branch
from
315d656 to
d9ec79f
Compare
jframe
approved these changes
Mar 12, 2024
Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
MASDXI
pushed a commit
to MASDXI/besu
that referenced
this pull request
Mar 13, 2024
…e it (besu-eth#6675) * Don't start a BFT mining coordinator when it is created, just enable it Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update change log Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: MASDXI <sirawitt42@gmail.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…e it (besu-eth#6675) * Don't start a BFT mining coordinator when it is created, just enable it Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update change log Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
…e it (besu-eth#6675) * Don't start a BFT mining coordinator when it is created, just enable it Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update change log Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: amsmota <antonio.mota@citi.com>
matthew1001
added a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
…e it (besu-eth#6675) * Don't start a BFT mining coordinator when it is created, just enable it Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update change log Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
When creating a BFT mining coordinator, if the sync phase is already complete then enable the coordinator but don't start it.
Start will be done either during starting of the ethereum main loop, or on receiving an event notification that syncing has completed.
Fixed Issue(s)
Fixes #6674