Feature/use gnark-crypto for eip-196 precompiles#7262
Merged
garyschulte merged 3 commits intobesu-eth:mainfrom Jul 17, 2024
Merged
Feature/use gnark-crypto for eip-196 precompiles#7262garyschulte merged 3 commits intobesu-eth:mainfrom
garyschulte merged 3 commits intobesu-eth:mainfrom
Conversation
4ed3a3a to
1099630
Compare
macfarla
approved these changes
Jun 27, 2024
Contributor
|
LGTM except there are 10 tests failing GeneralStateReferenceTest_507 > execution(String, GeneralStateTestCaseEipSpec, boolean) > Name: idPrecomps-Berlin[5] FAILED |
9980359 to
579c053
Compare
579c053 to
e9399f8
Compare
This was referenced Jul 12, 2024
Merged
e9399f8 to
3d1ad04
Compare
3d1ad04 to
6967245
Compare
… match target dirs Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
6967245 to
8e4c8a7
Compare
jflo
approved these changes
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Use gnark-crypto from besu-native for ECC precompiles
This will get besu onto a supported and more performant ECC library, and should allow us to remove tech debt in besu-native.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests