gnark-crypto, eip-196: malformed input handling#188
Merged
garyschulte merged 3 commits intobesu-eth:mainfrom Jul 11, 2024
Merged
gnark-crypto, eip-196: malformed input handling#188garyschulte merged 3 commits intobesu-eth:mainfrom
garyschulte merged 3 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
changed the title
… error and output length rather than static vals Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
changed the title
Signed-off-by: garyschulte <garyschulte@gmail.com>
pinges
approved these changes
Jul 10, 2024
pinges
left a comment
pinges
left a comment
There was a problem hiding this comment.
LGTM. I like that we are getting rid of that edge case :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECADD and ECMUL:
This change is consistent with reference tests and parameter parsing in other crypto implementations, and clarifies the edge cases (and language) described in the original eip:
https://eips.ethereum.org/EIPS/eip-196#test-cases
using this pr, clean run of besu#7626 :