Add RPC HTTP options to specify custom truststore and password#7978
Merged
macfarla merged 18 commits intobesu-eth:mainfrom Dec 18, 2024
Merged
Add RPC HTTP options to specify custom truststore and password#7978macfarla merged 18 commits intobesu-eth:mainfrom
macfarla merged 18 commits intobesu-eth:mainfrom
Conversation
added 3 commits
December 3, 2024 12:51
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
macfarla
reviewed
Dec 4, 2024
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
…nto 7932-rpc-http-truststore
macfarla
added
the
doc-change-required
macfarla
changed the title
macfarla
reviewed
Dec 5, 2024
Contributor
macfarla
left a comment
macfarla
left a comment
There was a problem hiding this comment.
with the error messages, it's helpful for the user to indicate exactly which CLI option is missing or required. Otherwise i think it's looking good
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
added 2 commits
December 6, 2024 13:40
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
…nto 7932-rpc-http-truststore
macfarla
reviewed
Dec 9, 2024
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/cli/options/JsonRpcHttpOptions.java
Outdated
Show resolved
Hide resolved
…pOptions.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
…pOptions.java Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
Contributor
|
There is a unit test failing. You can run these tests locally, this will benefit your time and reviewers. You'll get feedback waaaayy faster. converting to draft since it's not ready to review |
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Contributor
Author
I agree, no change is too small to skip running local tests. Fixed and ran the tests locally. |
macfarla
approved these changes
Dec 18, 2024
macfarla
changed the title
daniellehrner
pushed a commit
to daniellehrner/besu
that referenced
this pull request
Dec 18, 2024
…eth#7978) * Add RPC HTTP options to specify custom truststore and it's password * Update error logs to indicate options to use Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> --------- Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com> Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
alexandratran
removed
the
doc-change-required
pullurib
added a commit
to pullurib/besu
that referenced
this pull request
Feb 6, 2025
…eth#7978) * Add RPC HTTP options to specify custom truststore and it's password * Update error logs to indicate options to use Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> --------- Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com> Co-authored-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
#7932