Block transaction selector performance#9023
Merged
fab-10 merged 2 commits intobesu-eth:mainfrom Aug 27, 2025
Merged
Conversation
fab-10
force-pushed
the
block-transaction-selector-performance
branch
2 times, most recently
from
7f93ead to
7bb3544
Compare
matkt
reviewed
Jul 30, 2025
...n/java/org/hyperledger/besu/ethereum/blockcreation/txselection/BlockTransactionSelector.java
Show resolved
Hide resolved
matkt
reviewed
Aug 26, 2025
| for (final var pendingAction : selectedTxPendingActions) { | ||
| pendingAction.run(); | ||
| } | ||
| selectedTxPendingActions.clear(); |
Contributor
There was a problem hiding this comment.
is it normal that this one is removed ?
Contributor
Author
There was a problem hiding this comment.
it is done below at line 359, since there is no more the intermediate return
fab-10
force-pushed
the
block-transaction-selector-performance
branch
from
7bb3544 to
bf839d5
Compare
matkt
approved these changes
Aug 27, 2025
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
block-transaction-selector-performance
branch
from
bf839d5 to
f264f37
Compare
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Aug 28, 2025
* Improve performance of block creation Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Sep 8, 2025
* Improve performance of block creation Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Sep 8, 2025
* Improve performance of block creation Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: jflo <justin+github@florentine.us>
georgereuben
pushed a commit
to georgereuben/besu
that referenced
this pull request
Sep 16, 2025
* Improve performance of block creation Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: georgereuben <reubengeorge101@gmail.com>
georgereuben
pushed a commit
to georgereuben/besu
that referenced
this pull request
Sep 16, 2025
* Improve performance of block creation Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: georgereuben <reubengeorge101@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This PR improves the performance of the block creation phase, reducing the time spent during the commit of the world state updaters, see the screenshot below that compares the time spent for the commit, between a control Besu running 25.7.0 and a dev Besu running this PR.
Thanks to @ahamlat and @matkt for spotting this PR and suggesting how performance could be improved
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests