Add constants for private event #5205
Conversation
This patch is the first one for the private event feature. Here we add the basic constants and other data structures. We keep the commit small enough to test the workflow, too. Change-Id: I1953443499471eafcfca5e03ad805027453b26a1 Signed-off-by: Baohua Yang <[email protected]> Signed-off-by: Baohua Yang <[email protected]>
|
The UT failure is caused by unstable gossip: --- FAIL: TestWithStaticDeliverClientBothStaticAndLeaderElection (90.03s) |
|
What is the "private event feature"? Is there an RFC or issue with a description of the intended functionality and implementation approach? |
What is this feature for? Who sponsored this feature, as @yacovm and @bestbeforetoday pointed out, prior to introducing one of the series commits of some unknown feature without any explanation or, at very least, providing a few words of meaningful motivation, should be done through an RFC submission, check here: https://github.com/hyperledger/fabric-rfcs. Meanwhile, I would close it, and we will be able to reopen once we figure out what you are trying to achieve here. Please follow the project contribution guidelines and accepted processes. |
|
RFC has been put at hyperledger/fabric-rfcs#62. |
Dear @yeasy, you don't need to rush and re-open the current PR. There is a standard RFC acceptance process that should be followed, voted on, and accepted, and only then will it make sense to have incoming PRs in this regard. Meanwhile, it will remain open, and no one will go over it before the RFC process completes; therefore, closing it for now. Once the RFC is accepted, please open it again. |
This patch is the first one for the private event feature. Here we add the basic constants and other data structures.
We keep the commit small enough to test the workflow, too.
Change-Id: I1953443499471eafcfca5e03ad805027453b26a1
Type of change
Description
Add the basic constants and other data structures for the private event
Additional details
N/A.
Related issues
N/A.