Skip to content

Please correct AccelLimit in updatePositionAccelController_MC #10669

Open
@and-sh

Description

@and-sh

Current Behavior

AccelLimit code suppress pid output even to zero when target and set velocity are close to each over. Pid output is directly linked to banking angle. In result when MC hold position or move with constant velocity banking angle erratically falls to zero.
Pictures are in #10576

Steps to Reproduce

Poshold in windy day.

Expected behavior

Smooth and precision MC moves.

Suggested solution(s)

Disable accel limits. Correct accel limit realization is too complicated and probably not worth the effort to implement.
Banking angle is already limited.

Additional context

All version of Inav have this problem at leat 9 years.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions