Deploy improvements

[evansiroky]

Checklist

• Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
• Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
• The description lists all applicable issues this PR seeks to resolve
• The description lists any configuration setting(s) that differ from the default settings
• All tests and CI builds passing

Description

This is a companion PR to ibi-group/datatools-server#282. This PR does the following:

• Modifies the deployment UI to:
  • setting a custom AMI ID for graph builds only
  • setting a custom instance type for graph builds only
  • setting a custom region for the deployment
  • tolerate valid JSONC in the values for a custom build-config.json or router-config.json

[codecov-io]

Codecov Report

Merging #536 into dev will decrease coverage by 28.77%.
The diff coverage is 7.27%.

@@            Coverage Diff             @@
##             dev     #536       +/-   ##
==========================================
- Coverage   44.6%   15.82%   -28.78%     
==========================================
  Files        314      314               
  Lines      17114    16211      -903     
  Branches    5229     4941      -288     
==========================================
- Hits        7633     2566     -5067     
- Misses      8267    11618     +3351     
- Partials    1214     2027      +813

Flag	Coverage Δ
#end_to_end_tests	?
#unit_tests	15.82% <7.27%> (-0.19%)	⬇️

Impacted Files	Coverage Δ
lib/manager/util/deployment.js	61.9% <ø> (-19.05%)	⬇️
lib/admin/components/ServerSettings.js	0% <ø> (-32.49%)	⬇️
lib/manager/components/CurrentDeploymentPanel.js	17.39% <0%> (-53.45%)	⬇️
lib/manager/components/CollapsiblePanel.js	34.78% <11.11%> (-54.7%)	⬇️
lib/common/components/FormInput.js	17.07% <3.44%> (-63.58%)	⬇️
lib/manager/components/DeploymentViewer.js	17.24% <33.33%> (-48.19%)	⬇️
lib/common/util/json.js	11.76% <9.09%> (-71.57%)	⬇️
lib/manager/components/validation/TripsChart.js	0% <0%> (-80.4%)	⬇️
lib/editor/util/objects.js	14.89% <0%> (-78.73%)	⬇️
...nager/components/validation/ServicePerModeChart.js	0% <0%> (-78.27%)	⬇️
... and 265 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcfcf1c...3d16208. Read the comment docs.

[landonreed]

Nice work. Good idea on the JSONC tolerance.

[landonreed]

Sorry for not catching this earlier. But what is the JSONC parser supposed to permit? Can you provide a little more detail either here or in the CustomConfig component?

[landonreed]

It might be good to ref the function in OTP that parses JSON and match what is allowed there: https://github.com/opentripplanner/OpenTripPlanner/blob/27f4ed0a86157bdd4c4bc3004fec25687768d373/src/main/java/org/opentripplanner/standalone/OTPMain.java#L190-L194

So, to refine this a bit, can you allow unquoted field names also?

[landonreed]

Can you add a little more detail about the JSONC parser tolerance?

[evansiroky]

Request changes added to the best of my abilities.

[evansiroky]

More comments added.

[evansiroky]

This PR now also allows configuration of a deployment that recreates the build image.

[landonreed]

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀