Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

Deploy button in editor does not report errors #967

Open
@rabbah

Description

@rabbah
Contributor

i created an action which failed to deploy (controller misconfiguration) but no error was given in the shell; inspecting the console logs showed Uncaught (in promise) OpenWhiskError with a meaningful error message which clued me in that I didn't configure my controller correctly.

the shell should not silently fail to deploy but perhaps report an error somewhere obvious - wdyt?

Activity

starpit

starpit commented on May 21, 2018

@starpit
Member

agreed! you did a wsk action create foo bar.js or ?

and what did you see in the repl/command output?

rabbah

rabbah commented on May 21, 2018

@rabbah
ContributorAuthor

i used new x --kind nodejs:8 (but was missing the kind on the backend).
there was no ouptut on the repl side.
the only indicator that something was off is that the editor didn't change at all after clicking deploy.

starpit

starpit commented on May 21, 2018

@starpit
Member

oh, i see now. the error was when you clicked the Deploy button. if so, then yes! this is a large gap. the underlying problem here is that the Deploy button is not a good shell citizen; i.e. it initiates a side-effecting operation without involving the REPL, and hence it either needs to invent its own "head", or it fails to report status in the absence of a head (as is the case now).

changed the title [-]failure to deploy (at least for a new action) does not report any obvious errors in the shell[/-] [+]Deploy button in editor does not report errors[/+] on May 21, 2018
starpit

starpit commented on May 21, 2018

@starpit
Member

similarly, if you are editing a composition, and the composition has parse errors... these, too, fail silently right now.

starpit

starpit commented on May 29, 2018

@starpit
Member

actually, we already have some error reporting capability, as show in the screenshot. (even that is incomplete, as the text of the error message is only visible in the tooltip of the red dot, but it's functional, at lest)

so it sounds like the issue reported initially is indeed more one of error handling, than error reporting capability

screen shot 2018-05-29 at 13 38 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @starpit@rabbah

        Issue actions

          Deploy button in editor does not report errors · Issue #967 · ibm-functions/shell