This repository was archived by the owner on Apr 15, 2026. It is now read-only.
suppress hashie log#17
Merged
Merged
Conversation
houndci-bot
reviewed
Jan 13, 2018
| module Instagram | ||
| class HashieWrapper < ::Hashie::Mash | ||
| disable_warnings | ||
| end |
There was a problem hiding this comment.
end at 6, 2 is not aligned with class at 4, 1.
|
|
||
| module Instagram | ||
| class HashieWrapper < ::Hashie::Mash | ||
| disable_warnings |
There was a problem hiding this comment.
Tab detected.
Trailing whitespace detected.
| require 'hashie' | ||
|
|
||
| module Instagram | ||
| class HashieWrapper < ::Hashie::Mash |
There was a problem hiding this comment.
Use 2 (not 1) spaces for indentation.
Tab detected.
Missing top-level class documentation comment.
Trailing whitespace detected.
| @@ -0,0 +1,7 @@ | |||
| require 'hashie' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| }.merge(connection_options) | ||
|
|
||
| FaradayMiddleware::Mashify.mash_class = HashieWrapper | ||
|
|
houndci-bot
reviewed
Jan 13, 2018
| class HashieWrapper < ::Hashie::Mash | ||
| disable_warnings | ||
| end | ||
|
|
There was a problem hiding this comment.
Extra empty line detected at module body end.
| module Instagram | ||
| # Custom hashie mash class so that it suppresses the log on warnings. | ||
| class HashieWrapper < ::Hashie::Mash | ||
| disable_warnings |
There was a problem hiding this comment.
Use 2 (not 1) spaces for indentation.
Tab detected.
Trailing whitespace detected.
zhu1230
force-pushed
the
suppress_hashie_log
branch
from
31c35a3 to
4a8e426
Compare
zhu1230
force-pushed
the
suppress_hashie_log
branch
from
4a8e426 to
3786313
Compare
icco
approved these changes
Jan 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for getting rid of the warning message from Hashie.
Also, cleaned up the logger.
Thanks!