api/pinterest: return fetch.empty if a link is invalid #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wukko
requested changes
Jun 3, 2025
wukko
reviewed
Jun 7, 2025
wukko
approved these changes
Jun 8, 2025
Member
wukko
left a comment
wukko
left a comment
There was a problem hiding this comment.
lgtm
though we should probably rewrite the entire pinterest module in the future
wukko
changed the title
fetch.empty for invalid links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply checks if the pin linked is valid, and throws the proper error that it can't find the media.
Before
After