Skip to content

imp(api)!: refactor client relevant APIs to allow independent ICS-02 integration #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 8, 2024
Merged

imp(api)!: refactor client relevant APIs to allow independent ICS-02 integration #1115

merged 11 commits into from
Mar 8, 2024

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Mar 5, 2024 •
edited
Loading

Closes: #1114

Integration tests: informalsystems/basecoin-rs#166

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.70035% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 66.51%. Comparing base (65d8446) to head (79b8d70).

Files Patch % Lines
...core/ics24-host/cosmos/src/validate_self_client.rs 0.00% 18 Missing ⚠️
ibc-query/src/core/client/query.rs 0.00% 10 Missing ⚠️
...nts/ics07-tendermint/src/client_state/execution.rs 73.07% 7 Missing ⚠️
ibc-testkit/src/testapp/ibc/clients/mod.rs 56.25% 7 Missing ⚠️
ibc-testkit/src/testapp/ibc/core/core_ctx.rs 76.66% 7 Missing ⚠️
ibc-query/src/core/channel/query.rs 0.00% 5 Missing ⚠️
ibc-query/src/core/connection/query.rs 0.00% 5 Missing ⚠️
ibc-core/ics02-client/context/src/context.rs 0.00% 3 Missing ⚠️
.../ics24-host/cosmos/src/upgrade_proposal/handler.rs 0.00% 1 Missing ⚠️
ibc-testkit/src/testapp/ibc/core/client_ctx.rs 97.56% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   66.56%   66.51%   -0.06%     
==========================================
  Files         208      209       +1     
  Lines       20733    20725       -8     
==========================================
- Hits        13801    13785      -16     
- Misses       6932     6940       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani mentioned this pull request Mar 5, 2024
Merged
5 tasks
@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review March 5, 2024 21:43
@Farhad-Shabani Farhad-Shabani mentioned this pull request Mar 5, 2024
Merged
rnbguy
rnbguy requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @Farhad-Shabani ! 🚀

I added my first batch of reviews 🙂

rnbguy
rnbguy requested changes Mar 7, 2024
View reviewed changes
rnbguy
rnbguy approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏🏻

Great work 🚀

@Farhad-Shabani Farhad-Shabani merged commit 4f0ab6a into main Mar 8, 2024
@Farhad-Shabani Farhad-Shabani deleted the farhad/refactor-client-apis branch March 8, 2024 04:29
@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Mar 12, 2024
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@Farhad-Shabani
imp(api)!: refactor client relevant APIs to allow independent ICS-02 …
4af1222 
…integration (#1115)

* imp: refactor client-related APIs to allow independent ICS-02 integration

* chore: add unclog

* imp: keep self methods in ICS24 context + better signature for validate_self_client

* nit: revert naming to host_consensus_state

* imp: use client prelude for context relevant imports

* nit: rename to HostClient/ConsensusState

* imp: use trait bounds instead of ClientStateMut

* imp: move away from AnyConsensusState assoc type at ICS07

* docs: add a docstring for client_update_meta

* chore: further clean-ups

* fix: revert to the initial design approach using ClientStateMut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnbguy rnbguy rnbguy approved these changes

@seanchen1991 seanchen1991 seanchen1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.51.0
Development

Successfully merging this pull request may close these issues.

Refactor client-related APIs for modularity and allow independent ICS-02 integration
3 participants
@Farhad-Shabani @rnbguy @seanchen1991