-
Notifications
You must be signed in to change notification settings - Fork 0
fix(rust/signed-doc): Apply new document ref and fix validation rules #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bkioshn
wants to merge
12
commits into
fix/mod-doc-ref
Choose a base branch
from
fix/apply-new-doc-ref
base: fix/mod-doc-ref
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bkioshn <[email protected]>
…doc ref Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
✅ Test Report | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Task could/should be picked up as work on the backend.
enhancement
New feature or request
review me
PR is ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applying the new
DocumentRefs
to the existing code.Related Issue(s)
Closes #323
Description of Changes
Using new minicbor decoder for
DocumentRefs
Updating the document rule for PROPOSAL, PROPOSAL COMMENT, and PROPOSAL SUBMISSION ACTION
Update the rule for field that uses
DocumentRefs
includingref
,reply
,template
,parameters
Add additional parameters Link Ref rule eg. Linked Reference Metadata in Proposal Comment.
Modify the Test including
signed_doc/tests
are now updateRelated Pull Requests
Changing DocumentRef structure is done in #355
Please confirm the following checks