Skip to content

fix(rust/signed-doc): Apply new document ref and fix validation rules #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: fix/mod-doc-ref
Choose a base branch
from

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jun 19, 2025

Description

Applying the new DocumentRefs to the existing code.

Related Issue(s)

Closes #323

Description of Changes

  • Using new minicbor decoder for DocumentRefs

  • Updating the document rule for PROPOSAL, PROPOSAL COMMENT, and PROPOSAL SUBMISSION ACTION

  • Update the rule for field that uses DocumentRefs including ref, reply, template, parameters

  • Add additional parameters Link Ref rule eg. Linked Reference Metadata in Proposal Comment.

  • Modify the Test including

    • How document is stored inside a map: before is Uuid -> Doc, now is DocumentRef -> Doc
    • Tests in signed_doc/tests are now update

Related Pull Requests

Changing DocumentRef structure is done in #355

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn changed the title Fix/apply new doc ref fix(rust/signed-doc): Apply new document ref and fix validation rules Jun 19, 2025
@bkioshn bkioshn self-assigned this Jun 19, 2025
@bkioshn bkioshn added this to Catalyst Jun 19, 2025
@bkioshn bkioshn added enhancement New feature or request backend Task could/should be picked up as work on the backend. review me PR is ready for review labels Jun 19, 2025
@bkioshn bkioshn moved this from New to 👀 In review in Catalyst Jun 20, 2025
@bkioshn bkioshn marked this pull request as ready for review June 20, 2025 02:34
@bkioshn bkioshn removed the review me PR is ready for review label Jun 20, 2025
@bkioshn bkioshn marked this pull request as draft June 20, 2025 07:56
@bkioshn bkioshn marked this pull request as ready for review June 20, 2025 12:35
@bkioshn bkioshn added the review me PR is ready for review label Jun 20, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 362/362}$ | ${\color{red}Fail: 0/362}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Task could/should be picked up as work on the backend. enhancement New feature or request review me PR is ready for review
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

1 participant