fix(toolbar): hide btn group if empty #144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a btn group was empty, it was still leaving his border to connect two groups. Also added a "CustomBtns" possibility to the hideIcons options
|
It should be better to use css to control it. |
I don't understand to be honest. Can you explain more ? |
instance-oom
pushed a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In the toolbar, when a btn group was empty, it was still leaving his border to connect two groups.
Fix: Added conditions in the btn group elements.
Also, I added a "CustomBtns" possibility to the hideIcons options, to hide it's btn group (usefull when you don't want custom buttons).