[SYCL][Doc] Add Graph Scheduler design documentation #1457

alexbatashev · 2020-04-02T12:58:40Z

Co-authored-by: Vlad Romanov [email protected]
Signed-off-by: Alexander Batashev [email protected]

Co-authored-by: Vlad Romanov <[email protected]> Signed-off-by: Alexander Batashev <[email protected]>

sycl/include/CL/sycl/detail/cg.hpp

sycl/source/detail/scheduler/commands.hpp

sycl/source/detail/scheduler/graph_builder.cpp

Signed-off-by: Alexander Batashev <[email protected]> Co-Authored-By: Artem Gindinson <[email protected]>

sergey-semenov

Most of these are minor grammar/style comments.

sycl/source/detail/scheduler/commands.hpp

sycl/source/detail/scheduler/graph_builder.cpp

sycl/source/detail/scheduler/scheduler.hpp

sycl/source/detail/scheduler/commands.hpp

sycl/source/detail/scheduler/scheduler.hpp

Signed-off-by: Alexander Batashev <[email protected]> Co-Authored-By: Romanov Vlad <[email protected]> Co-Authored-By: Sergey Semenov <[email protected]>

Signed-off-by: Alexander Batashev <[email protected]> Co-Authored-By: Sergey Semenov <[email protected]>

…duler_docs * origin/sycl: (26 commits) [Driver][SYCL] Move include/sycl header before other system header locations (intel#1492) [BuildBot] Improve usability of buildbot scripts (intel#1472) [NFC] Add GitHub actions badges to README file (intel#1496) [SYCL] Improve error handling for kernel invocation (intel#1209) [SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations (intel#1371) [SYCL] Move type checks to later in Semantic Analysis lifecycle (intel#1465) [CI] Download fixed versions of Python tools (intel#1485) [SYCL] Fix sub_group::broadcast (intel#1482) [SYCL][Test] Disable spec_const_redefine.cpp on all devices but HOST (intel#1488) [SYCL] Only export public API (intel#1456) [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary (intel#1475) [SYCL] Enable LIT testing with CUDA BE (intel#1458) [SYCL] Fix float to half-type conversion (intel#1395) [NFC] Cleanup unneded macro from builtins implementation (intel#1445) Enable cfg-printer LLVM lit tests only if LLVM linked statically (intel#1479) [SYCL][NFC] Reflect the "allowlist" renaming in the code (intel#1480) [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466) [SYCL][USM] Remove vestigial dead code (intel#1474) [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451) [Driver][SYCL] Emit an error if c compilation is forced (intel#1438) ...

Signed-off-by: Alexander Batashev <[email protected]>

keryell

Thanks for fixing and improving the comments. This is always appreciated!

sycl/source/detail/scheduler/scheduler.hpp

Signed-off-by: Alexander Batashev <[email protected]>

alexbatashev · 2020-04-14T06:19:38Z

@keryell @AlexeySachkov does it look better now?

keryell

That looks quite better! :-)

…duler_docs * origin/sycl: [SYCL][PI][CUDA] Implements get_native interoperability (intel#1332) [SYCL] Fix check-sycl test suite on systems w/o OpenCL (intel#1503) [SYCL][Doc] Update ExtendedAtomics documentation (intel#1487) [SYCL][CUDA] Expose context extended deleters on PI API (intel#1483) [SYCL][NFC] Remove a dropped environment variable from a test (intel#1506) [SYCL] Add opencl-aot to sycl-toolchain target (intel#1504) [SYCL] Allow to run deploy LIT tests from particular directory [SYCL][CUDA] Fix LIT testing with CUDA devices (intel#1300) [SYCL] Remove operator name keywords (intel#1501) [Driver][SYCL] Consider .lo files as static archives (intel#1500) [SYCL-PTX] Update the compiler design to describe the CUDA target (intel#1408) [SYCL] Fix library build on Windows (intel#1499) [SYCL][NFC] Refactor lit.cfg.py (intel#1452) [SYCL] Fixed sub-buffer memory allocation update (intel#1486) [SYCL] Ensure proper definition of spirv builtins for SYCL (intel#1393) [SYCL][CUDA] LIT XFAIL/UNSUPPORTED (intel#1303) [SYCL][Doc] Function-type kernel attribute extension (intel#1494)

romanovvlad

LGTM

romanovvlad · 2020-04-15T14:36:33Z

sycl/source/detail/scheduler/scheduler.hpp

+/// kernel should be executed.
+///
+/// The commands that contain explicit memory operations include copy, fill,
+/// update_host and other operations. It's up to implementation how to define


Suggested change

/// update_host and other operations. It's up to implementation how to define

/// update_host and other operations. It's up to implementation how to implement

??

I wonder if repetition in such cases is a stylistic mistake...

…c_abi_checks * origin/sycl: [SYCL][Driver] Enforce unique filenames when -save-temps is used (intel#1545) [SYCL] [xmethods] Allow replacing xmethod script (intel#1532) [SYCL] Add tests for inline asm feature (intel#1444) [SYCL][Doc] Add device_specific_kernel_queries extension. (intel#1540) [SYCL][USM] Remove unused header and unnecessary includes (intel#1537) Fix check-llvm dependencies (intel#1547) [SYCL] Add __SYCL_EXPORT to declaration of contextSetExtendedDeleter (intel#1531) [SYCL][Doc] Add static local memory query extension. (intel#1539) [SYCL][Doc] Add sycl_bitcast extension (intel#1541) [SYCL][NFC] Temporarily disable sporadically failing test (intel#1533) [SYCL][NFC] Adjust codeowners for sycl directory (intel#1529) [SYCL] Fix processing of spec consts referenced twice (intel#1524) [SYCL] Use correct macro name in export.hpp (intel#1527) [Driver][NFC] Fix -help information for -Xs options (intel#1530) [SYCL][Doc] Add Graph Scheduler design documentation (intel#1457) [SYCL] Add diagnostics for long double in device code (intel#1512) [SYCL] Add a mutex to state-modifying program functions (intel#1204) [SYCL][Test] Add Devicelib tests (intel#1256) [SYCL] Refactor semantic checks for variable types (intel#1513)

[SYCL][Doc] Add Graph Scheduler design documentation

3f710b7

Co-authored-by: Vlad Romanov <[email protected]> Signed-off-by: Alexander Batashev <[email protected]>

alexbatashev requested review from romanovvlad, AGindinson and sergey-semenov April 2, 2020 12:58

alexbatashev assigned romanovvlad Apr 2, 2020

AGindinson reviewed Apr 2, 2020

View reviewed changes

Apply suggestions from code review

5011e3d

Signed-off-by: Alexander Batashev <[email protected]> Co-Authored-By: Artem Gindinson <[email protected]>

sergey-semenov reviewed Apr 3, 2020

View reviewed changes

romanovvlad reviewed Apr 3, 2020

View reviewed changes

Apply suggestions from code review

d0b265e

Signed-off-by: Alexander Batashev <[email protected]> Co-Authored-By: Romanov Vlad <[email protected]> Co-Authored-By: Sergey Semenov <[email protected]>

alexbatashev requested a review from bader as a code owner April 9, 2020 08:11

alexbatashev and others added 4 commits April 9, 2020 11:15

Apply suggestions from code review

f6eb8ff

Signed-off-by: Alexander Batashev <[email protected]> Co-Authored-By: Sergey Semenov <[email protected]>

Address more comments

f9e6934

Signed-off-by: Alexander Batashev <[email protected]>

format

93c08b0

Signed-off-by: Alexander Batashev <[email protected]>

keryell reviewed Apr 10, 2020

View reviewed changes

sycl/source/detail/scheduler/scheduler.hpp Outdated Show resolved Hide resolved

AlexeySachkov reviewed Apr 10, 2020

View reviewed changes

sycl/source/detail/scheduler/scheduler.hpp Outdated Show resolved Hide resolved

Fix more comments

8bf29c7

Signed-off-by: Alexander Batashev <[email protected]>

keryell previously approved these changes Apr 15, 2020

View reviewed changes

alexbatashev dismissed keryell’s stale review via 160d890 April 15, 2020 07:34

alexbatashev requested a review from romanovvlad April 15, 2020 13:30

romanovvlad approved these changes Apr 15, 2020

View reviewed changes

bader merged commit ad441a0 into intel:sycl Apr 15, 2020

alexbatashev deleted the private/abatashe/scheduler_docs branch April 15, 2020 20:01

	/// update_host and other operations. It's up to implementation how to define
	/// update_host and other operations. It's up to implementation how to implement

[SYCL][Doc] Add Graph Scheduler design documentation #1457

[SYCL][Doc] Add Graph Scheduler design documentation #1457

Uh oh!

Conversation

alexbatashev commented Apr 2, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sergey-semenov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

keryell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alexbatashev commented Apr 14, 2020

Uh oh!

keryell left a comment

Choose a reason for hiding this comment

Uh oh!

romanovvlad left a comment

Choose a reason for hiding this comment

Uh oh!

romanovvlad Apr 15, 2020

Choose a reason for hiding this comment

Uh oh!

alexbatashev Apr 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!