[SYCL][Driver] Mark DeviceLib option as deprecated #18581
Conversation
Signed-off-by: jinge90 <[email protected]>
| @@ -7036,19 +7036,22 @@ def fsycl_dead_args_optimization : Flag<["-"], "fsycl-dead-args-optimization">, | |||
| def fno_sycl_dead_args_optimization : Flag<["-"], "fno-sycl-dead-args-optimization">, | |||
| HelpText<"Disables elimination of DPC++ dead kernel arguments">; | |||
| def fsycl_device_lib_EQ : CommaJoined<["-"], "fsycl-device-lib=">, | |||
| Flags<[NoXarchOption]>, | |||
| Flags<[Deprecated]>, | |||
There was a problem hiding this comment.
@jinge90, there is also an associated test clang/test/Driver/sycl-deprecated.cpp can that test be updated?
There was a problem hiding this comment.
Hi, @mdtoguchi
The sycl-deprecated.cpp is updated.
Thanks very much.
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
| // RUN: %clangxx -fsycl -fsycl-device-lib-jit-link %s -### 2>&1 \ | ||
| // RUN: | FileCheck %s --check-prefix=CHECK -DOPTION=-fsycl-device-lib-jit-link | ||
| // RUN: %clangxx -fsycl -fno-sycl-device-lib-jit-link %s -### 2>&1 \ | ||
| // RUN: | FileCheck %s --check-prefix=CHECK -DOPTION=-fno-sycl-device-lib-jit-link |
There was a problem hiding this comment.
Please add tests for -fno-sycl-device-lib and -fsycl-device-lib deprecation as well.
There was a problem hiding this comment.
Done.
Thanks very much.
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
Hi, @mdtoguchi and @sergey-semenov |
| @@ -37,120 +37,6 @@ | |||
| // SYCL_DEVICE_LIB_LINK_DEFAULT-SAME: "{{.*}}libsycl-fallback-imf-fp64.bc" | |||
| // SYCL_DEVICE_LIB_LINK_DEFAULT-SAME: "{{.*}}libsycl-fallback-imf-bf16.bc" | |||
|
|
|||
| /// ########################################################################### | |||
There was a problem hiding this comment.
Why clear out the -fsycl-device-lib-jit-link testing? We have only marked as deprecated with the intention to remove - but it hasn't been removed yet.
There was a problem hiding this comment.
Hi, @mdtoguchi
I kept all tests untouched but found all test cases using this deprecated option would lead to build failure in pre-ci when some strict cflags are added such as "-Werror=xxx", so I cleared all these tests by removing the option.
Removing -fsycl-device-lib-ji-link testing in driver lit test is just for aligning for sycl e2e tests, do you think we should keep it for now and remove then until we finally removed this option? If so, I will revert the clang driver lit test change.
Thanks very much.
There was a problem hiding this comment.
@jinge90, yes please revert the driver test removal, as the functionality is still there until we do a full removal of the option and associated behavior.
There was a problem hiding this comment.
Hi, @mdtoguchi
The driver lit test changes are reverted.
Thanks very much.
Signed-off-by: jinge90 <[email protected]>
We decide to remove sycl device library jit link path, the 1st step is to mark all related driver option as 'deprecated' and cleared all tests using these options.