-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL] Fix sycl::atomic
regression
#19015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexeySachkov
wants to merge
4
commits into
intel:sycl
Choose a base branch
from
AlexeySachkov:private/asachkov/fix-atomic-regression
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[SYCL] Fix sycl::atomic
regression
#19015
AlexeySachkov
wants to merge
4
commits into
intel:sycl
from
AlexeySachkov:private/asachkov/fix-atomic-regression
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up for intel#18839 which broke host compilation of `sycl::atomic`. The actual fix is just an addition of `#include <sycl/__spirv/spirv_ops.hpp>` to `sycl/atomic.hpp`. However, I didn't want `spirv_ops.hpp` appear again in `sycl/detail/core.hpp` and therefore I went further to make sure that `sycl/atomic.hpp` isn't used by `sycl/accessor.hpp` which prompted other changes in this PR.
aelovikov-intel
approved these changes
Jun 17, 2025
…atomic-regression
Wow, that Windows issue is persistent I honestly struggle to understand how this patch could cause it at all:
And I haven't been able to reproduce it so far, but I will make more attempts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #18839 which broke host compilation of
sycl::atomic
.The actual fix is just an addition of
#include <sycl/__spirv/spirv_ops.hpp>
tosycl/atomic.hpp
.However, I didn't want
spirv_ops.hpp
to appear again insycl/detail/core.hpp
and therefore I went further to make sure thatsycl/atomic.hpp
isn't used bysycl/accessor.hpp
which prompted other changes in this PR.