[UR][CUDA] Fix unmap of buffer WRITE_INVALIDATE_REGION mappings #19028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frasercrmck
approved these changes
Jun 18, 2025
aarongreig
approved these changes
Jun 18, 2025
|
While the UR CUDA fail is known, I still think that testing should run on this PR since it's changing that. |
callumfare
force-pushed
the
callum/fix_cuda_unmap_write_invalidate
branch
from
d790247 to
5d10c0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffers mapped with
UR_MAP_FLAG_WRITE_INVALIDATE_REGIONneed to copy back to the buffer's device memory when unmapped. The HIP adapter was already doing this, seems like an accidental omission in the CUDA adapter.