[DeviceSanitizer] Fix private base leak and reuse private base if possiblem #19038
+152
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingcong-wu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
yingcong-wu
changed the title
yingcong-wu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
yingcong-wu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
reviewed
Jun 18, 2025
| /** | ||
| * A RAII helper to run callback when destructing, useful for clean up resources | ||
| */ | ||
| struct ScopeGuard { |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug1: Leak, when private sahdow failed to allocate, the already allocated private base would not be freed.
Bug2: Leak, the old private base is never freed.
Improve: try to reuse private base just like we try to reuse private shadow.