Skip to content

[NFC][SYCL] Update sub_group LIT tests #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Conversation

vladimirlaz
Copy link
Contributor

@vladimirlaz vladimirlaz commented Jul 30, 2020

  • Remove sub_group/common_ocl.cpp because it duplicates
    sub_group/common.cpp and directly use OpenCL API that causes
    instability on some configurations.
  • Fix sub_group/shuffle*.cpp tests to align with shuffle_xor
    restrictions mentioned in spec: "If the result of the XOR is
    greater than max_sub_group_size then it is considered out-of-range"

@vladimirlaz vladimirlaz requested a review from a team as a code owner July 30, 2020 11:47
@vladimirlaz vladimirlaz requested a review from v-klochkov July 30, 2020 11:47
- Remove sub_group/common_ocl.cpp because it duplicates
  sub_group/common.cpp and directly use OpenCL API that causes
  instability on some configurations.
- Fix sub_group/shuffle*.cpp tests to align with  shuffle_xor
  restrictions mentioned in spec: "If the result of the XOR is
  greater than max_sub_group_size then it is considered out-of-range"
@bader bader changed the title [NFC][SYCL] fix LIT tests [NFC][SYCL] Update sub_group LIT tests Jul 30, 2020
@wuw2
Copy link
Contributor

wuw2 commented Jul 30, 2020

Please also update generic-shuffle.cpp

@vladimirlaz
Copy link
Contributor Author

Please also update generic-shuffle.cpp

done

@vladimirlaz
Copy link
Contributor Author

Submit to unblock dependencies uplift #2148 2148

@vladimirlaz vladimirlaz merged commit 17f0d2b into intel:sycl Jul 31, 2020
@vladimirlaz vladimirlaz deleted the fix_lit branch August 5, 2020 13:50
jsji pushed a commit that referenced this pull request Nov 16, 2023
d0ae239 adds RunTimeLang parameter to createEnumerationType function.
Use default value for the new parameter.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@865af5d
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants