Development #115
Merged
Development #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes default value for DbStorage.connection_string fronm ":memory:" to "wintermute.sqlite3"
that only spawns a single container and starts hackingBuddyGPT against that container
because we need an interactive shell to enter OPENAI_API_KEY
using gpt-3.5-turbo instead of gpt-4o-mini
Merge RAG usecase into HackerBuddy thank you @Qsan1
(help is not quite optimal, but whatever)
New Argument Parsing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces several enhancements and updates to improve usability, maintainability, and functionality. Key changes include adding a web-based Viewer/Replayer, refactoring the capability classes (with updated type annotations and function calling support), and updating dependency configurations and documentation.
Reviewed Changes
Copilot reviewed 109 out of 111 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/hackingBuddyGPT/resources/webui/static/client.js | Adds new client-side JS for interactive websocket-based logging and run tracking (includes a typo in property assignment). |
| src/hackingBuddyGPT/cli/wintermute.py | Refactors CLI argument parsing with new configurable command mapping. |
| src/hackingBuddyGPT/capabilities/* | Refactors several capability modules and adjusts exception handling and logging practices. |
| pyproject.toml, publish_notes.md, README.md | Updates dependency versions, project metadata, and detailed usage instructions. |
Files not reviewed (2)
- .env.example: Language not supported
- .env.example.aws: Language not supported
Comments suppressed due to low confidence (1)
src/hackingBuddyGPT/capabilities/psexec_test_credential.py:11
- The warnings.warn call is used in the call method, but there is no import for the warnings module. Please add 'import warnings' at the top of the file to prevent runtime errors.
class PSExecTestCredential(Capability):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and updates to the project, including configuration improvements, code refactoring, feature additions, and dependency updates. The changes aim to improve usability, maintainability, and functionality of the project. Below is a summary of the most important changes:
The big one is the addition of the new
ragusecase which enhances the existing linux priv-esc usecase.Configuration Enhancements:
.env.examplefor configuring SSH authentication and RAG-based settings..env.example.awsfor AWS-specific configurations, including SSH key-based authentication and OpenAI API settings.Feature Additions:
README.md. [1] [2]Code Refactoring:
Capabilityclass insrc/hackingBuddyGPT/capabilities/capability.pyto improve type annotations, enhance function calling support, and simplify code structure. [1] [2] [3] [4]MinimalLinuxPrivescclass to improve token handling and logging inperform_roundmethod.Dependency and Build Updates:
pyproject.tomlto include libraries likefastapi,uvicorn, andlangchain, and added optional dependencies for development and RAG use cases. [1] [2]pyproject.toml, and added instructions for publishing to PyPI inpublish_notes.md. [1] [2]Documentation Improvements:
README.mdwith detailed instructions for setup, use cases, and new features, including AWS-specific configurations and beta tools. [1] [2] [3]