-
Notifications
You must be signed in to change notification settings - Fork 236
Add IPFS Kademlia DHT Specification #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guillaumemichel
wants to merge
22
commits into
main
Choose a base branch
from
dht
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+790
−2
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6265f16
dht: initial draft
guillaumemichel 1d3f8d2
routing table
guillaumemichel 4d2b789
lookup process
guillaumemichel f1a6ef3
rpc messages
guillaumemichel 3bc396d
format
guillaumemichel a5eefc3
peer routing
guillaumemichel b811eaf
provider records
guillaumemichel ee9c473
ipns
guillaumemichel 9215300
format
guillaumemichel 59b0ff1
client optimizations
guillaumemichel 53fc4a7
diversity filter
guillaumemichel dc718c7
intro
guillaumemichel 7d97c19
chore: cosmetic editorials
lidel 294ff84
Merge branch main into dht
lidel 9eafd15
chore: manual link to bibliography
lidel 51690fc
addressing review
guillaumemichel fb43c86
provide clarifications
guillaumemichel 6859977
specify transports requirements
guillaumemichel cd85a7f
swarm clarifications
guillaumemichel 27d2a58
specify relation to libp2p kad-dht
guillaumemichel a75b7b4
mark protobuf ping message as deprecated
guillaumemichel 48e5458
require libp2p ping
guillaumemichel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| out/ | ||
| node_modules/ | ||
| super-linter.log | ||
| node_modules/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ editors: | |
| url: https://ipshipyard.com | ||
| xref: | ||
| - ipns-record | ||
| order: 0 | ||
| order: 3 | ||
| tags: ['routing'] | ||
| --- | ||
|
|
||
|
|
||
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: document uses "recommended" multiple times, are those all in the spirit of
RECOMMENDEDfrom RFC 2119 (meansSHOULD)?Or should (not pun intended) we replace those with specific
SHOULD/MAYper case basis?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the "recommended" are for values/strategies that can be defined freely by implementers, they are not part of the protocol. In this case, "recommended" is more of a suggestion for values/strategies already used in implementations, e.g a safe default. Implementers are free to choose different values/strategies if they have other needs.
Hence the nuance should (not pun intended) be less than
SHOULDbut more thanMAY. I thinkSHOULDis closer though.I can either:
SHOULD