New versions for JJA (v6) and ASO(v4) added for Guate_AA, new attempt #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-kaplan
approved these changes
Aug 4, 2025
|
BTW there's a |
|
Yeah, it is ready for deployment to public. datasets guatemala/prcp-jja-v6 and guatemala/prcp-aso-v4 would need to be synced (I can send a separate email for that.) About the guatemala-may config, we don't need it anymore, should I delete it in a new branch? Btw, is it ok if I delete closed branches I opened? |
|
No need for a separate email. Yes, if you could submit a PR that removes guatemala-may that would be great. What are we doing with prcp-jja-v5? That's still sitting in fbf-candidate, not synced to fbf. |
|
Ok I will remove may. Let's keep prcp-jja-v5 a little longer in candidate in case it is brought back by partners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @aaron-kaplan , new attempt here. Thanks for the review, I added the version to be displayed as default this time and seems like there's no conflicts.