-
Notifications
You must be signed in to change notification settings - Fork 6
South Ethiopia bad years #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks ok for now, but be warned that this kind of hack will get harder to do when we switch from the db to shapefiles. You may have to construct the top-level shape by hand and save it to a file. Or else we need another iteration of the code, to support complex queries on shapefiles. |
@mm5330 ready to merge and deploy this? |
yes thank you! apologies, I think I accidentally made this one PR instead of two separate ones as intended. |
Here are some links to look at if you want to try to fix that: https://postgis.net/docs/ST_CoverageClean.html |
Note - these only cover 2022-1990. I am leaving non-mentioned years as null values for now. This is not ideal IMO, but it's something we'll need to discuss a solution for as a group. Leaving it like this for now, at Dan's request