Skip to content

Conversation

mm5330
Copy link
Contributor

@mm5330 mm5330 commented Oct 6, 2025

Note - these only cover 2022-1990. I am leaving non-mentioned years as null values for now. This is not ideal IMO, but it's something we'll need to discuss a solution for as a group. Leaving it like this for now, at Dan's request

@mm5330 mm5330 requested a review from aaron-kaplan October 6, 2025 16:56
@aaron-kaplan
Copy link
Collaborator

Looks ok for now, but be warned that this kind of hack will get harder to do when we switch from the db to shapefiles. You may have to construct the top-level shape by hand and save it to a file. Or else we need another iteration of the code, to support complex queries on shapefiles.

@aaron-kaplan
Copy link
Collaborator

@mm5330 ready to merge and deploy this?

@mm5330
Copy link
Contributor Author

mm5330 commented Oct 6, 2025

@mm5330 ready to merge and deploy this?

yes thank you! apologies, I think I accidentally made this one PR instead of two separate ones as intended.

@aaron-kaplan aaron-kaplan merged commit 2b09af4 into master Oct 6, 2025
1 check passed
@aaron-kaplan aaron-kaplan deleted the mm_southethiopia_badyears branch October 6, 2025 17:24
@aaron-kaplan
Copy link
Collaborator

There appear to be several enclaves that are excluded from the regions. Is that the actual political situation, or is this an artifact of imprecision in the shapes being unioned?

image

@mm5330
Copy link
Contributor Author

mm5330 commented Oct 6, 2025 via email

@aaron-kaplan
Copy link
Collaborator

Here are some links to look at if you want to try to fix that:

https://postgis.net/docs/ST_CoverageClean.html
https://postgis.net/docs/ST_CoverageUnion.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants