Support video frame output for Cosmos #2005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Francois-Lafleche
requested review from
Mayankm96,
jsmith-bdai,
jtigue-bdai,
kellyguo11 and
pascal-roth
as code owners
kellyguo11
reviewed
Mar 4, 2025
| @@ -237,6 +239,8 @@ def image( | |||
| data_type: str = "rgb", | |||
| convert_perspective_to_orthogonal: bool = False, | |||
| normalize: bool = True, | |||
| save_image_to_file: bool = False, | |||
There was a problem hiding this comment.
let's include these in the docstring as well
| os.makedirs(dir_path, exist_ok=True) | ||
| if images.dtype == torch.uint8: | ||
| images = images.float() / 255.0 | ||
| for tile in range(images.shape[0]): |
There was a problem hiding this comment.
would be good to have an option to save all tiles to a single file or save each tile individually. this might get a bit too much when we have lots of tiles.
There was a problem hiding this comment.
Agreed. My inclination would be to use a callback pattern - then the user can do any post-processing they'd like - perhaps save only ever 100 observation, or save only RGB, etc.
There was a problem hiding this comment.
ah yes, that's a good idea!
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
kellyguo11
merged commit 762b9cf
into
isaac-sim:chengrongl/randomization_selection_data_generation
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there