Skip to content

Initializes extras dict before loading managers #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2025
Merged

Initializes extras dict before loading managers #2178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
567f5db
Init extras dict before loading managers
kousheekc Mar 27, 2025
2317eac
added my name to contributors.md
kousheekc Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ Guidelines for modifications:
* Johnson Sun
* Kaixi Bao
* Kourosh Darvish
* Kousheek Chakraborty
* Lionel Gulich
* Louis Le Lay
* Lorenz Wellhausen
Expand Down
6 changes: 3 additions & 3 deletions source/isaaclab/isaaclab/envs/manager_based_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ def __init__(self, cfg: ManagerBasedEnvCfg):
# counter for simulation steps
self._sim_step_counter = 0

# allocate dictionary to store metrics
self.extras = {}

# generate scene
with Timer("[INFO]: Time taken for scene creation", "scene_creation"):
self.scene = InteractiveScene(self.cfg.scene)
Expand Down Expand Up @@ -170,9 +173,6 @@ def __init__(self, cfg: ManagerBasedEnvCfg):
# if no window, then we don't need to store the window
self._window = None

# allocate dictionary to store metrics
self.extras = {}

# initialize observation buffers
self.obs_buf = {}

Expand Down