Adds print info in disassembly direct environment #2750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
reviewed
Jun 23, 2025
| @@ -880,6 +876,10 @@ def _save_log_traj(self): | |||
| with open(log_filename, "w+") as out_file: | |||
| json.dump(log_item, out_file, indent=6) | |||
|
|
|||
| print("Trajectory collection complete! Collected %d trajectories." % len(self.log_arm_dof_pos)) | |||
There was a problem hiding this comment.
Could you switch it to use f-strings in Python? :)
https://docs.python.org/3/tutorial/inputoutput.html#fancier-output-formatting
There was a problem hiding this comment.
Thanks for your comment! I pushed a commit to change the string format.
Mayankm96
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add more information in the print out message, when generating disassembly paths.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there