Skip to content

Integrates NoiseModel to manager-based workflows #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2025

Conversation

ozhanozen
Copy link
Contributor

Description

This PR adds NoiseModel support for manager-based workflows. To achieve this, I have:

  • Added NoiseModel lifecycle management to ObservationManager.
  • Added a Callable field, func, to NoiseModelCfg, which ObservationManager uses to assign the class instance within, similar to how it is done for ModifierBase.
  • Renamed apply() to be __call()__, to be consistent with function-based noises and ModifierBase.

Fixes #2715 and #1864.

Note: I left the changelog with the entry [Unreleased] until the PR is given the green light.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11
Copy link
Contributor

@zoctipus could you help review this one please?

@zoctipus
Copy link
Contributor

yeah, happy to view!

Copy link
Contributor

@ooctipus ooctipus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the pull request, I have run few test locally and they seems to be well behaving. LGTM

@kellyguo11 kellyguo11 merged commit ea717fa into isaac-sim:main Jun 25, 2025
3 of 4 checks passed
@ozhanozen ozhanozen deleted the feat/manager-based-noise-model branch June 27, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Support NoiseModel class in ObservationManager
4 participants