Integrates NoiseModel
to manager-based workflows
#2755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
NoiseModel
support for manager-based workflows. To achieve this, I have:NoiseModel
lifecycle management toObservationManager
.Callable
field,func
, toNoiseModelCfg
, whichObservationManager
uses to assign the class instance within, similar to how it is done forModifierBase
.apply()
to be__call()__
, to be consistent with function-based noises andModifierBase
.Fixes #2715 and #1864.
Note: I left the changelog with the entry [Unreleased] until the PR is given the green light.
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there