Skip to content

Add math tests for transforms, rotations, and conversions (#103) #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jtigue-bdai
Copy link
Collaborator

@jtigue-bdai jtigue-bdai commented Jun 27, 2025

Description

this PR adds tests for:
scale_transform
unscale_transform
saturate
normalize
copysign
convert_quat
quat_conjugate
quat_from_euler_xyz
quat_from_matrix
euler_xyz_from_quat
matrix_from_euler
quat_from_angle_axis
axis_angle_from_quat
skew_symmetric_matrix
combine_transform
subtract_transform
compute_pose_error
Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@jtigue-bdai jtigue-bdai self-assigned this Jun 30, 2025
Signed-off-by: James Tigue <[email protected]>
@jtigue-bdai jtigue-bdai marked this pull request as ready for review June 30, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant