Transform: fix toString() method #2526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // System.out.println("Group 9 (Scale Y): " + matcher.group(9)); | ||
| // System.out.println("Group 10 (Scale Z): " + matcher.group(10)); | ||
| // } | ||
|
|
There was a problem hiding this comment.
Did you mean to commit this?
There was a problem hiding this comment.
Yes, I left them on purpose. The legend of the indices of the "groups" makes the test easier to understand; otherwise, it is difficult to understand the choice of those used later.
There was a problem hiding this comment.
I'm not sure how they help with that. They seem like bits of commented out code
There was a problem hiding this comment.
I have replaced the bits of code with clearer comments. I hope you feel more confident now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Transform Serialization, Imports, and toString Formatting
Transform.javafor clarity and explicitness.toString()method to useString.formatwithLocale.USfor consistent formatting and improved readability of translation, rotation, and scale values.e→ex,importer→im).writeandreadmethods for better maintainability.