Skip to content

Refactor: Uniform optimization + javadoc #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

capdevon
Copy link
Contributor

@capdevon capdevon commented Jun 25, 2025

This PR refactors the Uniform class in com.jme3.shader to improve code clarity, maintainability, and usage safety. Key changes include:

  • Replacing wildcard and redundant imports with explicit class imports.
  • Improving null checks, input validation, and variable naming for clearer intent.
  • Unifying and simplifying handling of value assignment in setValue.
  • Replacing manual hashCode and equals implementations with Objects.hash and Objects.equals.
  • Adding and enhancing Javadoc comments for public methods and class-level documentation.
  • Using meaningful constants for location checks and buffer allocation.
  • Ensuring proper buffer cleanup in deleteNativeBuffers with explanatory comments.
  • General code cleanup, minor bug fixes, and consistency improvements.

These updates make the Uniform class easier to understand, safer to use, and better documented for both users and maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant