Dockerfile update with compose file and README materials#376
Open
ajatoledo wants to merge 3 commits intojacksonliam:masterfrom
Open
Dockerfile update with compose file and README materials#376ajatoledo wants to merge 3 commits intojacksonliam:masterfrom
ajatoledo wants to merge 3 commits intojacksonliam:masterfrom
Conversation
e5e3be2 to
0114cc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile change - I updated the
ENTRYPOINTto remove the hard-coded output argument ofoutput_http.so -w ./wwwand added it to theCMDinput.The update allows users to update stream parameters using command arguments as part of their docker call. Previously, users could not adjust output arguments without mapping a volume to their container.
Updated file path:
./mjpg-streamer/mjpg-streamer-experimental/DockerfileExample Docker Compose - Added an example
docker-compose.ymlto illustrate how to configure a container using an image built with theDockerfileUpdated README - Added a new Docker section, which outlines how users can:
mjpg-streamerimage using provided Dockerfiledocker rundocker compose