This repository was archived by the owner on May 18, 2020. It is now read-only.
updated Prometheus endpoint#133
Open
rajputvishwas wants to merge 4 commits intojaegertracing:masterfrom
Open
Conversation
objectiser
suggested changes
Apr 6, 2020
Contributor
objectiser
left a comment
objectiser
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Could you also make the same changes to the jaeger-production-template.yml:
- agent metrics port should be 14271
- collector metrics port should be 14269
- query metrics port ahould be 16687
| - containerPort: 5778 | ||
| protocol: TCP | ||
| - containerPort: 16686 | ||
| - containerPort: 14269 |
Contributor
There was a problem hiding this comment.
You shouldn't replace the existing port here - instead add another entry for the admin port.
based on Fix Prometheus endpoint #17264, 16686 is now replaced with 14269. Signed-off-by: Rajput Vishwas <rajput_vishwas@infosys.com>
query-http port will remains 16686 Signed-off-by: Rajput Vishwas <rajput_vishwas@infosys.com>
also need to update all-in-one port Signed-off-by: Rajput Vishwas <rajput_vishwas@infosys.com>
updated as per suggestion Signed-off-by: Rajput Vishwas <rajput_vishwas@infosys.com>
Member
|
We are going to deprecate the repository. Please have a look at https://github.com/jaegertracing/jaeger-operator/#experimental-generate-kubernetes-manifest-file and share your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on Fix Prometheus endpoint #17264, 16686 is now replaced with 14269.
Which problem is this PR solving?
Short description of the changes