Remove executable as an argument to containers#87
Remove executable as an argument to containers#87jpkrohling merged 4 commits intojaegertracing:masterfrom
Conversation
zdicesare
force-pushed
the
feature/dockerfile-entrypoint
branch
from
9dcc5f0 to
85473ca
Compare
jpkrohling
changed the title
jaeger-production-template.yml
Outdated
| @@ -36,7 +36,6 @@ items: | |||
| - image: jaegertracing/jaeger-collector:1.2 | |||
There was a problem hiding this comment.
This image is still not following the changes from jaegertracing/jaeger#815. You'll need a new version of those images and then change the YAML files here to use this new version.
|
I'm adding the WIP tag to this PR, as there are tasks that need to be completed before this change:
|
|
Thanks for the patience here @jpkrohling :) |
Jaeger containers were changed to no longer require the path to the executable as an argument to docker run, so remove all instances of executable path Signed-off-by: Zachary DiCesare <zachary.v.dicesare@gmail.com>
zdicesare
force-pushed
the
feature/dockerfile-entrypoint
branch
from
85473ca to
5cb25e4
Compare
Signed-off-by: Zachary DiCesare <zachary.v.dicesare@gmail.com>
zdicesare
force-pushed
the
feature/dockerfile-entrypoint
branch
from
5cb25e4 to
8e6c6e8
Compare
|
The build will fail until 1.6.0 images are pushed |
|
I have a local branch bumping the version of https://github.com/kubernetes/charts/tree/master/incubator/jaeger However, since parameters are specified there via environment variables, I don't think a version bump will have an effect w/ the Dockerfile change, right? I could still bump the version anyways (currently it's at 1.4.1) if we want to update it. |
|
@jkandasa would you be able to test this PR this sprint? |
jpkrohling
left a comment
jpkrohling
left a comment
There was a problem hiding this comment.
I could test this and it failed locally. I got it working with the following changes:
https://gist.github.com/jpkrohling/75250433d508c53b407680fc9c67e547
@zdicesare, would you please update this PR to include the changes from the gist above? Once that's done, it's ready to be merged.
Needed now that Dockerfiles use ENTRYPOINT Signed-off-by: Zachary DiCesare <zachary.v.dicesare@gmail.com>
These are now packaged in the binary Signed-off-by: Zachary DiCesare <zachary.v.dicesare@gmail.com>
|
Yikes, my apologies @jpkrohling. First experience with k8s and openshift, but this was sloppy. |
|
It looks like these Travis failures are occurring on master as well |
jpkrohling
changed the title
|
Thank you for your contribution, @zdicesare! |
2 participants
Jaeger containers were changed to no longer require the path
to the executable as an argument to docker run, so remove all
instances of executable path
Signed-off-by: Zachary DiCesare zachary.v.dicesare@gmail.com