Add timezone tooltip to custom lookback form-field#161
Merged
Conversation
Signed-off-by: Joe Farro <joef@uber.com>
tiffon
requested review from
black-adder,
saminzadeh,
vprithvi and
yurishkuro
ghost
assigned
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 92.66% 92.77% +0.11%
==========================================
Files 85 85
Lines 1881 1882 +1
Branches 366 367 +1
==========================================
+ Hits 1743 1746 +3
+ Misses 126 124 -2
Partials 12 12
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Dec 24, 2017
| on="click" | ||
| wide="very" | ||
| trigger={<i className="SearchForm--hintTrigger info circle icon grey" />} | ||
| content={<h5>Times are expressed in {tz} timezone and converted to UTC</h5>} |
Member
There was a problem hiding this comment.
I would remove the part "and converted to UTC" from the tool tip, I don't think it's relevant to the user experience.
Signed-off-by: Joe Farro <joef@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Add timezone tooltip to custom lookback form-field Signed-off-by: Joe Farro <joef@uber.com> * Remove unnecessary info from tooltip Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2025
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [npm-run-all2](https://redirect.github.com/bcomnes/npm-run-all2) | [`7.0.1` -> `8.0.1`](https://renovatebot.com/diffs/npm/npm-run-all2/7.0.1/8.0.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bcomnes/npm-run-all2 (npm-run-all2)</summary> ### [`v8.0.1`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v801) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v8.0.0...v8.0.1) ##### Commits - Merge pull request [#​159](https://redirect.github.com/bcomnes/npm-run-all2/issues/159) from bcomnes/dependabot/npm_and_yarn/minimatch-10.0.1 [`54af3ab`](https://redirect.github.com/bcomnes/npm-run-all2/commit/54af3abd3d9fe5c32d21c8bac8a5ef12b7b448aa) - Upgrade: Bump minimatch from 9.0.5 to 10.0.1 [`f50ddf4`](https://redirect.github.com/bcomnes/npm-run-all2/commit/f50ddf48a0622d5473a7f9480069ebec8c5acd45) - Merge pull request [#​170](https://redirect.github.com/bcomnes/npm-run-all2/issues/170) from bcomnes/fix-engine-range [`e43e670`](https://redirect.github.com/bcomnes/npm-run-all2/commit/e43e6705fedfa87b8d80200f9d55ceb943ad77c7) ### [`v8.0.0`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v800---2025-05-02) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v7.0.2...v8.0.0) ##### Commits - **Breaking change:** Raise engine floor to >= Node 20 [`b1b12f8`](https://redirect.github.com/bcomnes/npm-run-all2/commit/b1b12f858291a7b3d73b20b28ca134407d927166) - Merge pull request [#​169](https://redirect.github.com/bcomnes/npm-run-all2/issues/169) from bcomnes/node-20-or-greater [`bb27458`](https://redirect.github.com/bcomnes/npm-run-all2/commit/bb274582dadbaaeeb2c3a2c54b4171660fb92399) ### [`v7.0.2`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v702) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v7.0.1...v7.0.2) ##### Merged - Upgrade: Bump neostandard from 0.11.9 to 0.12.0 [`#164`](https://redirect.github.com/bcomnes/npm-run-all2/pull/164) - Upgrade: Bump codecov/codecov-action from 4 to 5 [`#161`](https://redirect.github.com/bcomnes/npm-run-all2/pull/161) ##### Commits - Raise cross-spawn version floor to ^7.0.6 [`45a9e19`](https://redirect.github.com/bcomnes/npm-run-all2/commit/45a9e191b75e0b76433409808b6219d1f4dffe83) - Merge pull request [#​163](https://redirect.github.com/bcomnes/npm-run-all2/issues/163) from bcomnes/dependabot/npm_and_yarn/mocha-11.0.1 [`285967a`](https://redirect.github.com/bcomnes/npm-run-all2/commit/285967a3fc5076d8c22ecb14823eb6fc274dd835) - Upgrade: Bump mocha from 10.8.2 to 11.0.1 [`5d1aea5`](https://redirect.github.com/bcomnes/npm-run-all2/commit/5d1aea58f17abd201515f737c06bbe8044d05d21) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yNjQuMCIsInVwZGF0ZWRJblZlciI6IjM5LjI2NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaGFuZ2Vsb2c6ZGVwZW5kZW5jaWVzIl19--> Signed-off-by: Mend Renovate <bot@renovateapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #154.
EST Timezone:
PST Timezone