fixes #167: 2 digit lookback (12h, 24h) parsing#168
Merged
tiffon merged 2 commits intojaegertracing:masterfrom Jan 15, 2018
golonzovsky:master
Merged
fixes #167: 2 digit lookback (12h, 24h) parsing#168tiffon merged 2 commits intojaegertracing:masterfrom golonzovsky:master
tiffon merged 2 commits intojaegertracing:masterfrom
golonzovsky:master
Conversation
Signed-off-by: golonzovsky <alex.golonzovsky@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
- Coverage 92.67% 92.62% -0.06%
==========================================
Files 85 85
Lines 1884 1884
Branches 368 368
==========================================
- Hits 1746 1745 -1
- Misses 125 126 +1
Partials 13 13
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Jan 13, 2018
| let end; | ||
| if (lookback !== 'custom') { | ||
| const unit = lookback[1]; | ||
| const unit = lookback.substr(-1); |
Member
There was a problem hiding this comment.
seems like we need a unit test
Signed-off-by: golonzovsky <alex.golonzovsky@gmail.com>
tiffon
approved these changes
Jan 15, 2018
Member
|
LGTM |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…racing#168) * fix 2 digit lookback (12h, 24h) parsing Signed-off-by: golonzovsky <alex.golonzovsky@gmail.com> * add double digit lookback options parsing test Signed-off-by: golonzovsky <alex.golonzovsky@gmail.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #167
current code assumes 1 digit format of lookback options