Skip to content

[Fix]: make reset icon in SDG more intuitive#2723

Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom
hari45678:sdg-improve
Apr 25, 2025
Merged

[Fix]: make reset icon in SDG more intuitive#2723
yurishkuro merged 1 commit intojaegertracing:mainfrom
hari45678:sdg-improve

Conversation

@hari45678
Copy link
Copy Markdown
Contributor

Which problem is this PR solving?

Description of the changes

  • Make the Reset icon more intuitive

How was this change tested?

  • Manually, Unit tests

Checklist

Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
@hari45678 hari45678 requested a review from a team as a code owner April 24, 2025 16:01
@hari45678 hari45678 requested review from jkowall and removed request for a team April 24, 2025 16:01
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (9938e2d) to head (4b0d9fa).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2723   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files         256      256           
  Lines        7934     7938    +4     
  Branches     2042     2045    +3     
=======================================
+ Hits         7679     7683    +4     
  Misses        254      254           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro
Copy link
Copy Markdown
Member

Make the Reset icon more intuitive

what does "more intuitive" mean specifically, can you elaborate? Screenshots?

@hari45678
Copy link
Copy Markdown
Contributor Author

hari45678 commented Apr 25, 2025

The reset button was previously an icon but it now looks like

image

Also, we were not allowed to erase/delete the Max Depth input. That is now allowed,
For example, a user wants to focus on a service but doesn't want a max depth (basically wants to view the whole graph). Now this behavior is supported. Previously, they were required to have some number in max depth field

image

The "reload" icon to unset focal service is not very intuitive. Maybe add a Reset button instead. Also allow erasing the depth value

This is from the comment #2691 (review)

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Apr 25, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Apr 25, 2025
Merged via the queue into jaegertracing:main with commit 6356d5b Apr 25, 2025
9 of 10 checks passed
nojaf pushed a commit to nojaf/jaeger-ui that referenced this pull request Apr 28, 2025
## Which problem is this PR solving?
- part of jaegertracing#2699

## Description of the changes
- Make the Reset icon more intuitive

## How was this change tested?
- Manually, Unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
nojaf pushed a commit to nojaf/jaeger-ui that referenced this pull request Apr 28, 2025
## Which problem is this PR solving?
- part of jaegertracing#2699

## Description of the changes
- Make the Reset icon more intuitive

## How was this change tested?
- Manually, Unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Signed-off-by: nojaf <florian.verdonck@outlook.com>
@hari45678 hari45678 deleted the sdg-improve branch May 4, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants