[Fix]: make reset icon in SDG more intuitive#2723
[Fix]: make reset icon in SDG more intuitive#2723yurishkuro merged 1 commit intojaegertracing:mainfrom
Conversation
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2723 +/- ##
=======================================
Coverage 96.78% 96.78%
=======================================
Files 256 256
Lines 7934 7938 +4
Branches 2042 2045 +3
=======================================
+ Hits 7679 7683 +4
Misses 254 254
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
what does "more intuitive" mean specifically, can you elaborate? Screenshots? |
|
The reset button was previously an icon but it now looks like Also, we were not allowed to erase/delete the Max Depth input. That is now allowed,
This is from the comment #2691 (review) |
## Which problem is this PR solving? - part of jaegertracing#2699 ## Description of the changes - Make the Reset icon more intuitive ## How was this change tested? - Manually, Unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
## Which problem is this PR solving? - part of jaegertracing#2699 ## Description of the changes - Make the Reset icon more intuitive ## How was this change tested? - Manually, Unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com> Signed-off-by: nojaf <florian.verdonck@outlook.com>


Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test