[Fix]: Reduce default minimum allowed zoom#2775
Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom May 17, 2025
Merged
[Fix]: Reduce default minimum allowed zoom#2775yurishkuro merged 1 commit intojaegertracing:mainfrom
yurishkuro merged 1 commit intojaegertracing:mainfrom
Conversation
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Contributor
Author
|
Current: Previous: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2775 +/- ##
=======================================
Coverage 96.86% 96.86%
=======================================
Files 256 256
Lines 7951 7951
Branches 2053 2076 +23
=======================================
Hits 7702 7702
Misses 248 248
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
added
the
changelog:bugfix-or-minor-feature
yurishkuro
approved these changes
May 17, 2025
vishvamsinh28
pushed a commit
to vishvamsinh28/jaeger-ui
that referenced
this pull request
May 19, 2025
## Which problem is this PR solving? - fixes jaegertracing#2699 ## Description of the changes - This PR allows reducing the default minimum zoon value so less number of nodes doesn't get too scaled ## How was this change tested? - Manually ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test