Skip to content

Add environment checks to prepare-release target#3512

Merged
jkowall merged 1 commit intomainfrom
fix/env-check-before-release
Apr 11, 2026
Merged

Add environment checks to prepare-release target#3512
jkowall merged 1 commit intomainfrom
fix/env-check-before-release

Conversation

@jkowall
Copy link
Copy Markdown
Contributor

@jkowall jkowall commented Feb 6, 2026

This PR adds a target to the that validates the Node.js version and ensures exists before running . This addresses issues where running the release preparation in an unconfigured environment causes problems.

@jkowall jkowall requested a review from a team as a code owner February 6, 2026 17:40
Copilot AI review requested due to automatic review settings February 6, 2026 17:40
@jkowall jkowall added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Feb 6, 2026
@jkowall jkowall enabled auto-merge February 6, 2026 17:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an environment validation step before running the release-preparation automation to reduce failures in unconfigured local environments.

Changes:

  • Introduce a check-env Makefile target to validate Node.js version (via .nvmrc) and the presence of node_modules.
  • Make prepare-release depend on check-env.
  • Update release artifacts (CHANGELOG.md and packages/jaeger-ui/package.json version).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
Makefile Adds check-env target and wires it into prepare-release.
packages/jaeger-ui/package.json Bumps workspace version to 2.15.0.
CHANGELOG.md Adds a v2.15.0 section with release notes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.21%. Comparing base (6f319e2) to head (f315274).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3512   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         330      330           
  Lines        9889     9889           
  Branches     2568     2568           
=======================================
  Hits         8822     8822           
  Misses        925      925           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jkowall
Copy link
Copy Markdown
Contributor Author

jkowall commented Apr 6, 2026

Addressed your feedback — simplified check-env to just run nvm use instead of the manual version comparison. Also rebased on latest main and dropped the unrelated version bump/CHANGELOG commits so this PR is now Makefile-only.

Replace manual Node version checking logic with a direct
nvm use call, per maintainer feedback.

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
@jkowall jkowall force-pushed the fix/env-check-before-release branch from c998e9e to f315274 Compare April 10, 2026 07:06
@jkowall jkowall added this pull request to the merge queue Apr 11, 2026
Merged via the queue into main with commit bdcf63b Apr 11, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants