Add environment checks to prepare-release target#3512
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an environment validation step before running the release-preparation automation to reduce failures in unconfigured local environments.
Changes:
- Introduce a
check-envMakefile target to validate Node.js version (via.nvmrc) and the presence ofnode_modules. - Make
prepare-releasedepend oncheck-env. - Update release artifacts (
CHANGELOG.mdandpackages/jaeger-ui/package.jsonversion).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
Makefile |
Adds check-env target and wires it into prepare-release. |
packages/jaeger-ui/package.json |
Bumps workspace version to 2.15.0. |
CHANGELOG.md |
Adds a v2.15.0 section with release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3512 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 330 330
Lines 9889 9889
Branches 2568 2568
=======================================
Hits 8822 8822
Misses 925 925
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Addressed your feedback — simplified |
Replace manual Node version checking logic with a direct nvm use call, per maintainer feedback. Signed-off-by: Jonah Kowall <jkowall@kowall.net>
c998e9e to
f315274
Compare
This PR adds a target to the that validates the Node.js version and ensures exists before running . This addresses issues where running the release preparation in an unconfigured environment causes problems.