refactor(plexus): migrate Node to functional component (#3392)#3531
Conversation
|
Hi @hharshhsaini, thanks for your contribution! To ensure quality reviews, we limit how many concurrent open PRs new contributors can open. This PR is currently on hold (Status: 9/1 open). We will automatically move this into the review queue once your existing PRs are merged or closed. Please see our Contributing Guidelines for details on our tiered quota policy. |
|
@hharshhsaini , i think for the issues whom you are creating PR's , someone has already created PR's for them , kindly look that first. @yurishkuro PTAL . |
@greedy-wudpeckr |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@hharshhsaini please address copilot comments. |
|
PR quota unlocked! @hharshhsaini, this PR has been moved out of the waiting room and into the active review queue:
Thank you for your patience. |
…#3392) Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>
4123b35 to
e4eb5ff
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3531 +/- ##
==========================================
+ Coverage 88.60% 88.68% +0.08%
==========================================
Files 299 300 +1
Lines 9484 9560 +76
Branches 2500 2449 -51
==========================================
+ Hits 8403 8478 +75
- Misses 1078 1079 +1
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@jkowall the export typing Copilot suggestion ( |
jkowall
left a comment
There was a problem hiding this comment.
Looks good, thanks @hharshhsaini
Which problem is this PR solving?
Description of the changes
Nodecomponent from a class-based component to a functional component withReact.memo()Nodeclass component extendingReact.PureComponentto a functional componentReact.memo()to preserve the shallow prop comparison behavior ofPureComponentrender()method and converted to direct return statementas unknown as <T = {}>(props: TProps<T>) => React.ReactElement | nullHow was this change tested?
Proof -
Checklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.