Skip to content

Part of Phase 3.2 (task 1): Remove dead searchUrl prop in the TracePage#3603

Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom
Parship12:remove-dead-searchUrl
Mar 13, 2026
Merged

Part of Phase 3.2 (task 1): Remove dead searchUrl prop in the TracePage#3603
yurishkuro merged 1 commit intojaegertracing:mainfrom
Parship12:remove-dead-searchUrl

Conversation

@Parship12
Copy link
Copy Markdown
Member

@Parship12 Parship12 commented Mar 13, 2026

Which problem is this PR solving?

Description of the changes

  • Remove the dead searchUrl prop as no code path reads this.props.searchUrl. The header still getting its "back to search (←)" URL via toSearch, which comes from the component's location prop.

How was this change tested?

  • Unit tests passing
  • Tested the "back to search" link
    • click on any trace
    • On the trace page, look at the top left of the header: click this ← button, you should be taken back to the search results page
  • Tested the span search filter

Checklist

AI Usage in this PR (choose one)

See AI Usage Policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Signed-off-by: Parship Chowdhury <parshipchowdhury@gmail.com>
@Parship12 Parship12 requested a review from a team as a code owner March 13, 2026 13:07
Copilot AI review requested due to automatic review settings March 13, 2026 13:07
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.15%. Comparing base (dc6be4d) to head (f8949bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3603      +/-   ##
==========================================
- Coverage   89.15%   89.15%   -0.01%     
==========================================
  Files         304      304              
  Lines        9727     9725       -2     
  Branches     2595     2593       -2     
==========================================
- Hits         8672     8670       -2     
+ Misses       1052     1051       -1     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused searchUrl prop from TracePage Redux props/state mapping, simplifying the component’s props surface as part of the ongoing Jaeger UI routing/state modernization.

Changes:

  • Drop searchUrl from TReduxProps and from mapStateToProps() in TracePage.
  • Remove the now-obsolete unit test that asserted fromSearch propagation via mapStateToProps(), and update expected props accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/jaeger-ui/src/components/TracePage/index.tsx Removes searchUrl from Redux-derived props and stops reading it from state.router.location.state.
packages/jaeger-ui/src/components/TracePage/index.test.js Updates mapStateToProps() expectations and removes the test for fromSearchsearchUrl propagation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Parship12
Copy link
Copy Markdown
Member Author

@yurishkuro ptal

@yurishkuro yurishkuro added the changelog:refactoring Internal, non-functional code improvements label Mar 13, 2026
@yurishkuro yurishkuro merged commit a88ca74 into jaegertracing:main Mar 13, 2026
17 of 19 checks passed
@Parship12 Parship12 changed the title Part of Phase 3.2 (task 2): Remove dead searchUrl prop Part of Phase 3.2 (task 2): Remove dead searchUrl prop in the TracePage Mar 14, 2026
@Parship12 Parship12 deleted the remove-dead-searchUrl branch March 14, 2026 06:12
@Parship12 Parship12 changed the title Part of Phase 3.2 (task 2): Remove dead searchUrl prop in the TracePage Part of Phase 3.2 (task 1): Remove dead searchUrl prop in the TracePage Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:refactoring Internal, non-functional code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants