Part of Phase 3.2 (task 1): Remove dead searchUrl prop in the TracePage#3603
Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom Mar 13, 2026
Merged
Conversation
Signed-off-by: Parship Chowdhury <parshipchowdhury@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
==========================================
- Coverage 89.15% 89.15% -0.01%
==========================================
Files 304 304
Lines 9727 9725 -2
Branches 2595 2593 -2
==========================================
- Hits 8672 8670 -2
+ Misses 1052 1051 -1
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unused searchUrl prop from TracePage Redux props/state mapping, simplifying the component’s props surface as part of the ongoing Jaeger UI routing/state modernization.
Changes:
- Drop
searchUrlfromTReduxPropsand frommapStateToProps()inTracePage. - Remove the now-obsolete unit test that asserted
fromSearchpropagation viamapStateToProps(), and update expected props accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/jaeger-ui/src/components/TracePage/index.tsx | Removes searchUrl from Redux-derived props and stops reading it from state.router.location.state. |
| packages/jaeger-ui/src/components/TracePage/index.test.js | Updates mapStateToProps() expectations and removes the test for fromSearch → searchUrl propagation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@yurishkuro ptal |
yurishkuro
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
searchUrlprop as no code path readsthis.props.searchUrl. The header still getting its "back to search (←)" URL viatoSearch, which comes from the component'slocationprop.How was this change tested?
Checklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.