Part of Phase 3.2 (task 1): factor out keyboard shortcut setup into a separate function in the TracePage#3609
Merged
yurishkuro merged 1 commit intojaegertracing:mainfrom Mar 14, 2026
Conversation
…rate function Signed-off-by: Parship Chowdhury <parshipchowdhury@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors TracePageImpl keyboard shortcut initialization by extracting the setup logic out of componentDidMount() into a dedicated helper method, improving readability while keeping behavior the same.
Changes:
- Moved keyboard shortcut wiring from
componentDidMount()into_setupKeyboardShortcuts(). - Updated the existing unit test to hook into
_setupKeyboardShortcuts()rather thancomponentDidMount().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/jaeger-ui/src/components/TracePage/index.tsx | Extracts keyboard shortcut setup into _setupKeyboardShortcuts() and calls it from componentDidMount(). |
| packages/jaeger-ui/src/components/TracePage/index.test.js | Adjusts the keyboard-shortcut setup test to patch _setupKeyboardShortcuts() for verifying adjViewRange wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3609 +/- ##
=======================================
Coverage 89.15% 89.15%
=======================================
Files 304 304
Lines 9725 9727 +2
Branches 2505 2593 +88
=======================================
+ Hits 8670 8672 +2
- Misses 1051 1052 +1
+ Partials 4 3 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
approved these changes
Mar 14, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
componentDidMountinto_setupKeyboardShortcuts.How was this change tested?
Checklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.