Skip to content

Do not fail bundle size workflow on main branch #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurishkuro merged 1 commit into from
Mar 21, 2026
+1 −1
Merged

Do not fail bundle size workflow on main branch #3653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check_bundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
jaeger-ui-bundle-size

- name: Compare bundle sizes
if: steps.cache-bundle-size.outputs.cache-matched-key != ''
if: steps.cache-bundle-size.outputs.cache-matched-key != '' && github.ref != 'refs/heads/main'
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if guard relies on cache-matched-key, but the workflow never saves a cache under the exact key jaeger-ui-bundle-size (it saves jaeger-ui-bundle-size-${{ github.run_id }}), so cache-matched-key will typically stay empty and the compare step will never run. Consider switching to a versioned save key (e.g. includes github.sha/run_id) and restoring via a prefix restore-keys (e.g. jaeger-ui-bundle-size-) so PRs can compare against the latest main baseline.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch check github.ref != 'refs/heads/main' is redundant with this workflow's triggers (push only runs on main) and is inconsistent with the later Save new bundle size step which keys off github.event_name. Using github.event_name != 'push' here would be clearer and avoids subtle ref differences across events like merge_group.

Suggested change
if: steps.cache-bundle-size.outputs.cache-matched-key != '' && github.ref != 'refs/heads/main'
if: steps.cache-bundle-size.outputs.cache-matched-key != '' && github.event_name != 'push'

Copilot uses AI. Check for mistakes.
run: |
OLD_BUNDLE_SIZE=$(cat bundle_size.txt)
NEW_BUNDLE_SIZE=$(cat new_bundle_size.txt)
Expand Down
Loading