Merged
Conversation
yurishkuro
reviewed
Apr 20, 2017
cmd/standalone/main.go
Outdated
| Param: 1.0, | ||
| }, | ||
| RPCMetrics: true, | ||
| }.InitGlobalTracer( |
Member
There was a problem hiding this comment.
what is the reason to init global tracer?
Contributor
Author
There was a problem hiding this comment.
so the standalone query service is instrumented.
Member
There was a problem hiding this comment.
my bad. We should change it to not use global tracer, but to expect tracer as an option.
yurishkuro
reviewed
Apr 20, 2017
cmd/standalone/standalone_test.go
Outdated
| fmt.Sprintf("%s:%s", queryHostPort, queryPort), | ||
| }) | ||
|
|
||
| resp, err := cli.ContainerCreate( |
Member
There was a problem hiding this comment.
the amount of dependencies this brings is very unfortunate. We don't use any of that for crossdock tests, why is it necessary here? Can't we run the test via docker-compose?
Contributor
Author
There was a problem hiding this comment.
We can... it's just more work... How adamant are you for keeping the number of dependencies low?
black-adder
force-pushed
the
add_standalone_test
branch
from
e5e5f4a to
41f4314
Compare
yurishkuro
approved these changes
Apr 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a test for the standalone docker image that creates a trace with via the query service and then retrieves it.