Allow tracer config via env vars#1919
Merged
yurishkuro merged 3 commits intojaegertracing:masterfrom Nov 12, 2019
Merged
Conversation
Signed-off-by: Yuri Shkuro <ys@uber.com>
added 2 commits
November 12, 2019 13:47
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #1919 +/- ##
==========================================
- Coverage 98.48% 98.45% -0.03%
==========================================
Files 198 198
Lines 9740 9740
==========================================
- Hits 9592 9590 -2
- Misses 113 114 +1
- Partials 35 36 +1
Continue to review full report at Codecov.
|
vprithvi
approved these changes
Nov 12, 2019
This was referenced Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Tested with all-in-one by running it on different port, re-pointing the tracer to the new port, and validating messages via tcpdump: