Allow the Configuration of Additional Headers on the Jaeger Query HTTP API#2056
Merged
yurishkuro merged 22 commits intojaegertracing:masterfrom Feb 8, 2020
Merged
Conversation
Member
Author
|
Functionality confirmed with local testing. Dropping Draft status. |
Codecov Report
@@ Coverage Diff @@
## master #2056 +/- ##
=========================================
+ Coverage 97.39% 97.4% +<.01%
=========================================
Files 207 209 +2
Lines 10307 10340 +33
=========================================
+ Hits 10039 10072 +33
Misses 224 224
Partials 44 44
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Feb 5, 2020
yurishkuro
reviewed
Feb 5, 2020
85f13cb to
4169a86
Compare
yurishkuro
reviewed
Feb 8, 2020
yurishkuro
reviewed
Feb 8, 2020
yurishkuro
reviewed
Feb 8, 2020
yurishkuro
reviewed
Feb 8, 2020
yurishkuro
reviewed
Feb 8, 2020
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Joe Elliott <number101010@gmail.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Joe Elliott <number101010@gmail.com>
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
aa68742 to
5e269c1
Compare
Signed-off-by: Joe Elliott <number101010@gmail.com>
Member
|
restarting unit tests to get the coverage numbers (call to codecov timed out) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
query.additional-headersthat allows for multiple headers to be added to jaeger query's api--query.additional-headers "Access-Control-Allow-Origin: https://mozilla.org" --query-additional-headers "Access-Control-Expose-Headers: X-My-Custom-Header"