Add Dockerfile for OTEL collector and publish latest tag#2167
Merged
pavolloffay merged 3 commits intojaegertracing:masterfrom Apr 6, 2020
Merged
Add Dockerfile for OTEL collector and publish latest tag#2167pavolloffay merged 3 commits intojaegertracing:masterfrom
pavolloffay merged 3 commits intojaegertracing:masterfrom
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
objectiser
approved these changes
Apr 6, 2020
Contributor
objectiser
left a comment
objectiser
left a comment
There was a problem hiding this comment.
LGTM - just the one query in Dockerfile.
| @@ -0,0 +1,8 @@ | |||
| FROM alpine:latest as certs | |||
| RUN apk --update add ca-certificates | |||
Contributor
There was a problem hiding this comment.
Should this be same as collector Dockerfile? RUN apk add --update --no-cache ca-certificates with --no-cache option?
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #2167 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 219 219
Lines 10585 10585
=======================================
Hits 10177 10177
- Misses 352 353 +1
+ Partials 56 55 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container name for OTEL collector is
jaegertracing/jaeger-opentelemetry-collector.Signed-off-by: Pavol Loffay ploffay@redhat.com