Enable batch and queued retry processors by default#2330
Merged
pavolloffay merged 3 commits intojaegertracing:masterfrom Jul 8, 2020
Merged
Enable batch and queued retry processors by default#2330pavolloffay merged 3 commits intojaegertracing:masterfrom
pavolloffay merged 3 commits intojaegertracing:masterfrom
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
+ Coverage 95.61% 95.65% +0.04%
==========================================
Files 205 205
Lines 10529 10529
==========================================
+ Hits 10067 10072 +5
+ Misses 395 391 -4
+ Partials 67 66 -1
Continue to review full report at Codecov.
|
objectiser
reviewed
Jul 7, 2020
| if len(resProcessor.Labels) > 0 { | ||
| processors[resProcessor.Name()] = resProcessor | ||
| } | ||
| processors := createProcessors(c.Factories) |
Contributor
There was a problem hiding this comment.
Could this method return the list of processor names aswell, rather than having a hardcoded list on line 89.
| } | ||
|
|
||
| func processorNames(processors configmodels.Processors) []string { | ||
| // processorNames returns processor names that are present in both input parameters |
Contributor
There was a problem hiding this comment.
Why would the list of processors be different?
Member
Author
There was a problem hiding this comment.
the resource processor is enabled only when needed.
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
objectiser
approved these changes
Jul 7, 2020
Contributor
objectiser
left a comment
objectiser
left a comment
There was a problem hiding this comment.
LGTM - merge on green
Member
|
need to re-trigger the build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2152 and open-telemetry/opentelemetry-collector#886
This PR enables by default
batchandqueued_retryOTEL processors.By default should be also enabled memory limiter, however it requires absolute settings which is not ideal solution for a single binary that is deployed in various environments. the memory limiter will support percentage settings in the future open-telemetry/opentelemetry-collector#1078.