Jaeger agent logs "0" whenever sampling strategies are requested#2382
Merged
jpkrohling merged 1 commit intojaegertracing:masterfrom Aug 11, 2020
jpkrohling:jpkrohling/issue2356
Merged
Jaeger agent logs "0" whenever sampling strategies are requested#2382jpkrohling merged 1 commit intojaegertracing:masterfrom jpkrohling:jpkrohling/issue2356
jpkrohling merged 1 commit intojaegertracing:masterfrom
jpkrohling:jpkrohling/issue2356
Conversation
Fixes #2356 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Contributor
Author
|
@agaudreault-jive, would you be able to try this out? |
Codecov Report
@@ Coverage Diff @@
## master #2382 +/- ##
==========================================
- Coverage 95.62% 95.61% -0.01%
==========================================
Files 206 206
Lines 10548 10547 -1
==========================================
- Hits 10086 10084 -2
Misses 395 395
- Partials 67 68 +1
Continue to review full report at Codecov.
|
objectiser
approved these changes
Aug 11, 2020
That was the one! 🎉 Thanks for finding it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de
Which problem is this PR solving?
Short description of the changes
fmt.Printlnfromsampling_from_domain