Skip to content

Fix unmarshalling in OTEL badger#2488

Merged
pavolloffay merged 2 commits intojaegertracing:masterfrom
pavolloffay:fix-otel-badger
Sep 17, 2020
Merged

Fix unmarshalling in OTEL badger#2488
pavolloffay merged 2 commits intojaegertracing:masterfrom
pavolloffay:fix-otel-badger

Conversation

@pavolloffay
Copy link
Copy Markdown
Member

Signed-off-by: Pavol Loffay ploffay@redhat.com

Resolves #2485

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay pavolloffay added storage/badger Issues related to badger storage area/otel labels Sep 17, 2020
@pavolloffay pavolloffay requested a review from a team as a code owner September 17, 2020 15:12
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Copy link
Copy Markdown
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Copy Markdown
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2488 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
+ Coverage   95.52%   95.53%   +0.01%     
==========================================
  Files         208      208              
  Lines       10759    10759              
==========================================
+ Hits        10277    10279       +2     
+ Misses        406      405       -1     
+ Partials       76       75       -1     
Impacted Files Coverage Δ
plugin/storage/badger/spanstore/reader.go 96.49% <100.00%> (ø)
cmd/query/app/server.go 90.69% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd57f3...585a57e. Read the comment docs.

@pavolloffay pavolloffay merged commit 5b9598d into jaegertracing:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/otel storage/badger Issues related to badger storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTEL Badger exporter fails to read/deserialize data

3 participants